Skip to content

ext/posix: posix_kill() process_id range check. #18944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ext/posix: posix_kill() process_id range check. #18944

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

pid_t is, for the most part, represented by a signed int, by overflowing it, we end up being in the -1 case which affect all accessible processes.

@devnexen
Copy link
Member Author

before going into a pid_t handling "killing spree" all over the extension, let me know if this is something wishable.

@devnexen devnexen force-pushed the posix_oflow_nonposix branch from 996cc69 to e9402c6 Compare June 25, 2025 22:04
@devnexen
Copy link
Member Author

cc @Girgias

@Girgias
Copy link
Member

Girgias commented Jul 12, 2025

I think this makes sense, as anything outside of this range seems to point to a bug

@devnexen devnexen force-pushed the posix_oflow_nonposix branch 2 times, most recently from a84a097 to c540a26 Compare July 12, 2025 17:03
@devnexen devnexen marked this pull request as ready for review July 12, 2025 17:16
@bukka
Copy link
Member

bukka commented Jul 15, 2025

What actually happens on -2 at the moment?

@devnexen
Copy link
Member Author

devnexen commented Jul 15, 2025 •
edited
Loading

hmmm looking at it now, negative numbers < -1 might be relevant cases (for kill), they normally aim for process groups in this case e.g. -2 -> process group 2 but will have a look later.

@devnexen devnexen force-pushed the posix_oflow_nonposix branch 2 times, most recently from 36f9542 to bc69cef Compare July 15, 2025 18:45
@devnexen
ext/posix: posix_kill() process_id range check.
a94236c 
pid_t is, for the most part, represented by a signed int, by overflowing
it, we end up being in the -1 case which affect all accessible processes.
@devnexen devnexen force-pushed the posix_oflow_nonposix branch from bc69cef to a94236c Compare July 15, 2025 19:14
Girgias
Girgias approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to do the same for group ids, etc.?
Also UPGRADING entry :)

bukka
bukka requested changes Jul 28, 2025
View reviewed changes
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah breaking group ids would be an issue so it cannot get merged untill this is sorted.

@devnexen
Copy link
Member Author

Are you going to do the same for group ids, etc.? Also UPGRADING entry :)

I might ... we ll see

@devnexen
Copy link
Member Author

Yeah breaking group ids would be an issue so it cannot get merged untill this is sorted.

What s the issue @bukka ? would any future plans be a blocker ?

@bukka
Copy link
Member

bukka commented Jul 28, 2025

Oh you updated it to min int. Sorry missed that part. That's fine then.

@devnexen devnexen closed this in 3b4f2b0 Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bukka bukka bukka approved these changes

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: posix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devnexen @Girgias @bukka