gen_stub: Fix undefined variable warning #18821
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> PHP Warning: Undefined variable $code in build/gen_stub.php on line 5322 Introduced in php#18735.
kocsismate
approved these changes
Jun 10, 2025
kocsismate
reviewed
Jun 10, 2025
| @@ -5313,6 +5313,8 @@ function generateGlobalConstantAttributeInitialization( | |||
| $constInfos, | |||
| "", | |||
| static function (ConstInfo $constInfo) use ($allConstInfos, $phpVersionIdMinimumCompatibility) { | |||
| $code = ""; | |||
There was a problem hiding this comment.
BTW isn't it easier to assign the $code variable on line 5318, instead of concatenating to it, or am I missing something?
There was a problem hiding this comment.
I felt that it would be more robust to always concatenate to not accidentally overwrite something when refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #18735.