Remove custom UTF-8 check function from ext/libxml #18706
Conversation
This was originally introduced as a workaround for a libxml2 bug [1]. This bug has been fixed for more than a decade, and we can use the libxml2 API again. [1] 7e53511
Since you are linking to the workaround, can you also link to the fix that makes this no longer needed? |
Done: GNOME/libxml2@3ffe90e |
There was a problem hiding this comment.
Fixed version was released in GNOME/libxml2@d1de4a3 libxml2-2.6.13
I suggest also linking to 74235ca where PHP's requirement upgraded from 2.6.11+ to 2.7.6+, ensuring that a fixed version was used
| @@ -62,6 +62,7 @@ PHP 8.5 INTERNALS UPGRADE NOTES | |||
|
|
|||
| - ext/libxml | |||
| . The refcount APIs now return an `unsigned int` instead of an `int`. | |||
| . Removed php_libxml_xmlCheckUTF8(). Use xmlCheckUTF8() from libxml instead. | |||
There was a problem hiding this comment.
Do we really not have an exported UTF-8 checking function ourselves?! I checked and couldn't find anything.
There was a problem hiding this comment.
Do we really not have an exported UTF-8 checking function ourselves?! I checked and couldn't find anything.
We have some mbstring APIs that AFAIK are exported, but then you need mbstring loaded..
There was a problem hiding this comment.
I suppose we'll have some due to ext/lexbor in master
This was originally introduced as a workaround for a libxml2 bug [1]. This bug has been fixed for more than a decade [2], and we can use the libxml2 API again.
A quick search reveals no public users of this API.
[1] 7e53511
[2] GNOME/libxml2@3ffe90e