Implement request #61105: Support Soap 1.2 SoapFault Reason Text lang attribute #18701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… attribute This is on the border line of a bugfix and a new feature. Anyway, this is necessary to fix compatibility with .NET clients.
Girgias
reviewed
May 29, 2025
| ZVAL_EMPTY_STRING(Z_FAULT_STRING_P(obj)); | ||
| ZVAL_NULL(Z_FAULT_CODE_P(obj)); | ||
| ZVAL_NULL(Z_FAULT_CODENS_P(obj)); | ||
| ZVAL_NULL(Z_FAULT_ACTOR_P(obj)); | ||
| ZVAL_NULL(Z_FAULT_DETAIL_P(obj)); | ||
| ZVAL_NULL(Z_FAULT_NAME_P(obj)); | ||
| ZVAL_NULL(Z_FAULT_HEADERFAULT_P(obj)); | ||
| ZVAL_NULL(Z_FAULT_LANG_P(obj)); |
There was a problem hiding this comment.
Should this maybe be:
Suggested change
| ZVAL_NULL(Z_FAULT_LANG_P(obj)); | |
| ZVAL_EMPTY_STRING(Z_FAULT_LANG_P(obj)); |
?
There was a problem hiding this comment.
I'm uncertain. The other things are nullable too. The language attribute is actually only applicable if the client requested SOAP 1.2, it's unimportant in SOAP 1.1. I suppose this should be changed to an empty string for simplicity but I'd have to think a bit.
Comment on lines
+1257
to
+1260
| add_soap_fault_ex(&exception_object, this_ptr, "Server", ZSTR_VAL(msg), NULL, NULL, SOAP_GLOBAL(lang_en)); | ||
| zend_string_release_ex(msg, 0); | ||
| } else { | ||
| add_soap_fault_ex(&exception_object, this_ptr, "Server", "Internal Error", NULL, NULL); | ||
| add_soap_fault_ex(&exception_object, this_ptr, "Server", "Internal Error", NULL, NULL, SOAP_GLOBAL(lang_en)); |
There was a problem hiding this comment.
Maybe having two new add_soap_fault_en{_ex}() APIs is better than passing that global into every call?
Similar to what you did with soap_server_fault_en()
|
The logic seems reasonable from really quick look and with my limited knowledge of SOAP. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on the border line of a bugfix and a new feature. Anyway, this is necessary to fix compatibility with .NET clients.