Add test for async client #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $headers['Content-Length'] = (string)strlen($body); | ||
| } | ||
|
|
||
| if (!($this->httpAdapter instanceof HttpAsyncClient)) { |
There was a problem hiding this comment.
Shouldn't this be the first thing?
|
Shouldn't we create two separate tests instead? Also, shouldn't we refactor tests to reflect the change from adapter to client? |
|
Hum yes may be better, i just go for the fastest right now to validate guzzle implementation, but will do this tests in a separate class |
|
This should be good. This need the merge of php-http/discovery#15 |
|
Updated with new repository for async, should be good to merge. |
|
Can you please squash commits? I think it makes sense in this case. |
|
done |
|
Thanks |
sagikazarmark
added a commit
that referenced
this pull request
Nov 5, 2015
Add test for async client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to php-http/httplug#77