Repository navigation
Conversation
The icons drew only the mark on a transparent background, so the light icon disappeared on dark surfaces and the dark icon on light ones. Each icon now fills its square, as Dify's official icons and photon.codes' favicons do: the #101010 mark on white, and the white mark on #101010.
ENG-4374 Give the Dify plugin icons Photon's solid backgrounds
The three Dify plugins in photon-hq/dify (the tool plugin at the root, Dify's official plugins draw their mark on a solid square, for example a white square in the light icons of GitHub and Slack and a dark square in Slack's dark icon. photon.codes uses solid tiles for its favicons as well: a white tile with a Done when:
|
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 6
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Summary
The icons of the three plugins (the tool plugin,
trigger/, andbot/) drew only the Photon mark on a transparent background: black inicon.svg, white inicon-dark.svg. The light icon disappeared on a dark surface and the dark icon on a light one, so every Dify surface had to pick the matching variant. Each icon now fills its square with a solid background, as Dify's official plugin icons do (for example, white squares in the light icons of GitHub and Slack, and a dark square in Slack's dark icon), in the colors of photon.codes' favicons.Closes ENG-4374
Before and after
icon.svg(light)#000000mark, transparent background#101010mark on a solid#FFFFFFsquareicon-dark.svg(dark)#FFFFFFmark, transparent background#FFFFFFmark on a solid#101010squareThe colors are sampled from photon.codes: its light favicon is a white tile with a
#101010mark, and its dark favicon a#101010tile with a white mark. The square covers the wholeviewBox, so no pixel is transparent; Dify rounds the corners where it shows icons. The mark keeps its size and position. The three plugins keep sharing the same two files.Testing
iconandicon_darkfiles exist and are not the template icon, which are the checks ofcheck-plugin-icons.shin langgenius/dify-official-plugins.Need help on this PR? Tag
@codesmithwith what you need.