Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 211 #216

Merged
merged 4 commits into from
Dec 25, 2017
Merged

Issue 211 #216

merged 4 commits into from
Dec 25, 2017

Conversation

yuranos
Copy link
Contributor

@yuranos yuranos commented Dec 11, 2017

Based on #211
@stojsavljevic , please review.

@stojsavljevic
Copy link
Contributor

@yuranos in #211 I stated that this is a feature not a bug :)
So what's the point of this PR?

@yuranos
Copy link
Contributor Author

yuranos commented Dec 12, 2017

HI, @stojsavljevic !
I created a PR before I saw your comment:)
Having said that, I think it's an unnecessary limitation. It's more common to use plural notation, but there's more than one way to skin a cat, i.e., a lot of people will argue otherwise.
My suggestion is not breaking anything that was already there, it's just making the decision based on something that is less debatable than naming convention(id in the path).
Do you see any potential problems with my idea?
Please, check for more evidence that the view is not one-sided:
https://stackoverflow.com/questions/6845772/rest-uri-convention-singular-or-plural-name-of-resource-while-creating-it
https://stackoverflow.com/questions/778203/are-there-any-naming-convention-guidelines-for-rest-apis
People have different views on pluralism vs singularity.

@yuranos
Copy link
Contributor Author

yuranos commented Dec 22, 2017

@stojsavljevic , time to get back to this one.

@stojsavljevic stojsavljevic merged commit cf982a0 into phoenixnap:master Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants