Skip to content

wasm: restore focused loading canaries and pin runtime ordering - #254

Draft
phlax with Copilot wants to merge 3 commits into
wasm-testsfrom
copilot/wasm-tests-canaries
Draft

phlax with Copilot wants to merge 3 commits into
wasm-testsfrom
copilot/wasm-tests-canaries

Conversation

Copilot AI commented Oct 25, 2026 •

Copy link
Copy Markdown

The Wasm test speed-ups narrowed source-compilation coverage and made runtime ordering load-bearing. This adds focused canaries without restoring expensive matrices or changing production behavior.

  • Loading coverage

    • Add test_cpp_source.wasm without precompilation.
    • Cover source loading with allow_precompiled unset and precompiled-section stripping with it explicitly false.
    • Add one V8/downstream/HTTP1 integration request/response using the source-only module.
  • Precompiled acceptance

    • Require a nonempty, V8-version-matched precompiled section and successful loading.
    • The pinned host exclusively deserializes that section; rejection fails loading rather than falling back. Failures already propagate to Envoy’s ERROR log, so no loader changes are needed.
  • Coverage invariants

    • Assert V8 is the first sandbox runtime when compiled in.
    • Document first-runtime ordering and preserve WasmCommonTest as the primary full-matrix suite.
  • Verification and limits

    • Formatting/lint, secret scanning, and Bazel target analysis passed.
    • Test execution remains unverified: the cold-cache runtime-test build expanded to approximately 4,000 actions and was stopped. CodeQL skipped C++ analysis due to database size.
    • Rust source-only coverage is deferred; all existing speed-ups remain intact.

Risk: low; test-only changes. Docs/release notes: N/A. AI-assisted implementation.

phlax and others added 2 commits October 25, 2026 12:26
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot AI changed the title [WIP] Add canary tests for Wasm test suites wasm: restore focused loading canaries and pin runtime ordering Oct 25, 2026
Copilot AI requested a review from phlax October 25, 2026 12:39
@phlax
phlax force-pushed the wasm-tests branch 9 times, most recently from 1dc7304 to 8b2e981 Compare October 26, 2026 21:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants