Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pick item props with config.transform #49

Closed
wants to merge 1 commit into from

Conversation

atian25
Copy link

@atian25 atian25 commented Nov 27, 2022

close #48

@atian25
Copy link
Author

atian25 commented Dec 11, 2022

ping @philipstanislaus any thoughts on this?

@philipstanislaus
Copy link
Owner

Hi @atian25, sorry for my very slow reply here. I wanted to eventually review this PR in detail but did not find the time amongst other responsibilities. Since this will not change in the near future, I decided to no longer maintain this repository.

Still, a few thoughts on your concept: I really like the idea of transforming data through a simple callback function. However, I believe it would be better to publish that as an alternative package, since many of the other config options would no longer be needed.

If you do (or did) publish this somewhere for people to use, feel free to add a link to #55.

I'm closing this PR and the related issue since this will not be merged anymore.

Anyways, thanks for sharing your suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: support pick item props
2 participants