Small improvements to RealtimeDataSource and Replicator#2
Open
danieljharris wants to merge 8 commits intophilfleck:icg_fleck_realtime_datasource_and_replicatorfrom
Conversation
…d_replicator Icg fleck realtime datasource and replicator
Note: You can upload images to github user content by pasting them into the web editor when editing a readme file
- Added RealtimeDataDemo script back to the demo scene (Somehow became "missing") - Removed unused variables from RealtimeDataDemo.cs - Removed commented out code from RealtimeDataDemo.cs - Fixed if statement in RealtimeDataDemo.cs
- Added regions to RealtimeDataSource.cs - Added check for maxVal >= minVal in RealtimeDataSource.cs - Added bool option for auto scaling called "cutoffDataToBeInsideMinMaxValues" in RealtimeDataSource.cs
- Removed unused "using" - Removed unused variables in RealtimeDataReplicationDemo.cs - Removed commented out code in RealtimeDataReplicationDemo.cs - Changed name of prefab created by the context menu - Fixed bug where SharedMaterial == null in BigMesh.cs when stopping the program - Fixed bug where Axies dictionary would not contain a key for an Axis in RealtimeDataReplicationDemo.cs - Converted UpdateDatasource function to use early returns in Replicator.cs to greatly reduce indentation
- Data dimension auto boundary scaling is now set on a per dimension basis - More small changes to Replicator.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some improvements to the RealtimeDataSource and some code cleanup changed to Replicator.
These are only suggestions, feel free to keep or not keep any changes you want 🙂
List of changes
Realtime Datasource
Replicator
Miscellaneous