Dedupe types requests #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only reverting the Python version bump wasn't sufficient, I'm going to try Pytest next.
I don't actually expect this one to fix the tests, but we decreased the Django version with that change, and if we had this version working before (which it seems like we did) we should keep it.
tornado and grpcio were added as newly-independently-declared dependencies, so my next guess is that maybe something needs a different version of one or both?
bw-file-resubmit==0.6.0rc2 had been removed in this commit; adding it back.
Seeing if tests still pass with these pins now that I've fixed them
With everything else back and only the dependency deletion reverted, tests still pass. Can we have Python 3.11, too???
We currently call for an identical version of types-requests twice at the very end of requirements.txt. This removes one of those lines.
|
We discussed this in person and we're pretty sure it was an accident, not a weird workaround. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently call for an identical version of types-requests twice at the very end of requirements.txt. This removes one of those lines.