Skip to content

Commit

Permalink
chore: typing, rename get_user to get_repo_user
Browse files Browse the repository at this point in the history
  • Loading branch information
phil65 committed Nov 15, 2024
1 parent 21e80f6 commit b3972d2
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions src/githarbor/core/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ def from_url(cls, url: str, **kwargs: Any) -> BaseRepository:
msg = f"{cls.__name__} does not implement from_url"
raise FeatureNotSupportedError(msg)

def get_user(self) -> User:
msg = f"{self.__class__.__name__} does not implement get_user"
def get_repo_user(self) -> User:
msg = f"{self.__class__.__name__} does not implement get_repo_user"
raise FeatureNotSupportedError(msg)

def get_branch(self, name: str) -> Branch:
Expand Down
2 changes: 1 addition & 1 deletion src/githarbor/core/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class User:
"""Personal blog of this user"""
twitter_username: str | None = None
"""X / Twitter username of this user"""
hireable: str | None = None
hireable: bool | None = None
"""Whether user is available for hiring"""
gravatar_id: str | None = None
"""Gravatar id for this user."""
Expand Down
4 changes: 2 additions & 2 deletions src/githarbor/core/proxy.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ def default_branch(self) -> str:
"""
return self._repository.default_branch

def get_user(self) -> User:
def get_repo_user(self) -> User:
"""Get information about the repository user.
Returns:
User information.
"""
return self._repository.get_user()
return self._repository.get_repo_user()

def get_branch(self, name: str) -> Branch:
"""Get information about a specific branch.
Expand Down
2 changes: 1 addition & 1 deletion src/githarbor/providers/gitearepository.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def get_branch(self, name: str) -> Branch:
return giteatools.create_branch_model(branch)

@giteatools.handle_api_errors("Failed to get repository owner info")
def get_user(self) -> User:
def get_repo_user(self) -> User:
"""Get user (repository owner) information."""
user = self._user_api.user_get_current()
return giteatools.create_user_model(user)
Expand Down
2 changes: 1 addition & 1 deletion src/githarbor/providers/githubrepository.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def iter_files(
yield content.path

@githubtools.handle_github_errors("Failed to get repository owner info")
def get_user(self) -> User:
def get_repo_user(self) -> User:
"""Get user (repository owner) information."""
return githubtools.create_user_model(self.user)

Expand Down
6 changes: 3 additions & 3 deletions src/githarbor/providers/gitlabrepository.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ def default_branch(self) -> str:
return self._repo.default_branch

@gitlabtools.handle_gitlab_errors("Failed to get user info")
def get_user(self) -> User:
def get_repo_user(self) -> User:
"""Get user (repository owner) information."""
user = self._gl.users.list(username=self._owner)[0]
user = self._gl.users.list(username=self._owner)[0] # type: ignore
return gitlabtools.create_user_model(user)

@gitlabtools.handle_gitlab_errors("Branch {name} not found")
Expand Down Expand Up @@ -385,4 +385,4 @@ def list_tags(self) -> list[Tag]:

if __name__ == "__main__":
repo = GitLabRepository("phil65", "test")
print(repo.get_user())
print(repo.get_repo_user())

0 comments on commit b3972d2

Please sign in to comment.