New halt implementation #18026
New halt implementation #18026
Conversation
…he compiler, parse, semantic analysis and the rest
|
As a bonus no need for the compiler, not reparse and semantical analysis. |
|
Working on reimplementing HaltCount: too. |
| @@ -184,24 +193,36 @@ Halt class >> onCountWithBehavior: behaviorBlock [ | |||
| Halt class >> once [ | |||
| "Stop once and only once the execution of the method containing the expression Halt once. If you need to get it stops another time after the first stop, use Halt resetOnce." | |||
|
|
|||
| | callingContext senderContext node | | |||
| <debuggerCompleteToSender> | |||
There was a problem hiding this comment.
Maybe the pragma should be kept, because this is used to hint the debugger that this method should be filtered from the shown stack by default (and usually we want to stop at the caller, not here right?
Or maybe it's not needed? What does the debugger show when this halts without the pragma?
There was a problem hiding this comment.
I mean, if you do Halt once directly in a method
There was a problem hiding this comment.
Tx I thought that I kept it so I will added back
Now there is a bug because we should not be forced to do Halt initializeOnCount before. I just commit to get a stable point.
…his is mandatory else running twice the test will fail."
|
Ready for review. |
a new implementation of haltOnce with nice tests showing that
executing two times in a row the same haltOnce call will bark only the first time and
that we can have multiple call sites in the same method with each one their own "counter"