Ux fix for the strange browser toggle buttons #17929
Open
+83
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hum... The first option can never be checked. Just for this one I wonder if letting the little pen button that was there before is not better? If some people want to give their opinion here is the new look: 
|
|
Fixes #16484 too |
|
@jecisc do we ask people opinion now or should we take a decision |
|
We will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17827
Fixes #16484
-Made the buttons look all the same with checkboxes, changed the labels of the button
-Now we can enable/disable everything by using checkboxes, it is more explicit than just clicking on the labels like before
-Line count is not turned on by default still because we want to have people opinion on it