Limit assess_size_codebase to only .R files #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #362 ## Description This change only list files with R source code. An example of a "valid" package where this metric fails is [bayesPop](https://cran.r-project.org/web/packages/bayesPop/index.html) because it has an RDA file inside the R directory.
Gotfrid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #362
Description
This change is related to assess_size_codebase metric, when it is being assessed on a local source code. It currently fails for packages that have .rda files inside the R folder. Examples: acss.data, bayesPop.
The proposed change is to only list files with .R extension.