Added NetBSD processor affinity support. #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added processor affinity support for NetBSD to xhprof. I've tested the changes on Linux and MacOS but not FreeBSD (as I don't currently have have access to a FreeBSD box).
A couple of notes:
GET_AFFINITY
/SET_AFFINITY
macros, I'm ignoringpid
and callingpthread_self()
instead. It's only ever currently called with apid
argument of 0 (ie. self) anyway...cpu_set_t
to be pointers, and are allocating memory for thecpu_set_t
/cpuset_t
structure. This is because on NetBSD, thecpuset_t
structure is declared but not defined in the headers. NetBSD providescpuset_*
functions to create, manipulate and sizeofcpuset_t
structures.tests/xhprof_005
an it fails with the following output. Without a good understanding of how the usleep stuff works, I'm a bit unsure of what might be going on here; any ideas?Let me know if there is anything else you'd like me to change as part of this pull request.
Cheers,
Timshel