Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hp_execute_internal segfault on 5.6. #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msonnabaum
Copy link

This should address the issue found in #63.

One approach could be to add an additional if clause for 5.6 and inline 5.6's version of execute_internal. Before doing that, I checked uprofiler to see how/if they'd addressed it and they did more or less what's in the PR here.

It's not clear to me why hp_execute_internal has inlined execute_internal in the past (performance optimization?), but it seems like calling execute_internal directly will be considerably easier to maintain.

This also adds a test from the example in #63.

@beberlei
Copy link

This change is a bit inefficient, because it uses the variables from EG global space instead of directly from zend_execute_data which is passed to the function anyways.

You could use our fork https://github.com/tideways/php-profiler-extension which adds PHP 5.6 support as well, performance improvements and is generally maintained. You can even use the precompiled binaries/packages for some systems from here: https://tideways.io/profiler/downloads

hexmode pushed a commit to hexmode/xhprof that referenced this pull request Jan 12, 2023
Change version into php_xhprof.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants