Skip to content

Commit

Permalink
release v2.0.0 compatible with biopython version 1.85 now
Browse files Browse the repository at this point in the history
  • Loading branch information
kbessonov1984 committed Jan 22, 2025
1 parent 0ce6ef3 commit 600687c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Install dependencies. On Ubuntu distro run

Install python dependencies via `pip`:
```
pip3 install pandas "biopython<1.85"
pip3 install pandas "biopython<=1.85"
```
Clone the repository or checkout a particular release (e.g `v1.0.0`, `v2.0.0` etc.):
```
Expand All @@ -93,7 +93,7 @@ pip3 install . # option 2
- mash >= 2.0

### Python packages:
- biopython >= 1.70,<1.85 (see issue #99)
- biopython >= 1.70,<=1.85
- pandas >= 0.23.1
- requests >= 2.0

Expand Down Expand Up @@ -346,4 +346,4 @@ Licensed under the Apache License, Version 2.0 (the "License"); you may not use

[http://www.apache.org/licenses/LICENSE-2.0](http://www.apache.org/licenses/LICENSE-2.0)

Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
2 changes: 1 addition & 1 deletion ectyper/speciesIdentification.py
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ def getSampleName(file):

def is_valid_fasta_file(fasta, sampleName):
# try to read the first sequence of FASTA file and make a format validity decision. No reason to check all reads
for contig in SeqIO.parse(fasta, "fasta").records:
for contig in SeqIO.parse(fasta, "fasta"):
if contig.seq != '':
LOG.debug(f'{sampleName}: input file {fasta} is a valid FASTA')
return True
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
license='Apache 2',
scripts=['bin/ectyper'],
packages=['ectyper'],
install_requires=['requests','biopython<1.85','pandas<3'],
install_requires=['requests','biopython<=1.85','pandas<3'],
package_data={'ectyper': ['Data/*.json', 'Data/*.py']},
zip_safe=False,
test_suite='py.test',
Expand Down

0 comments on commit 600687c

Please sign in to comment.