Skip to content

fix: removed inject decorator provided by dependency_injector #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/api/routers/bidding.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

from api.dependencies import get_application
from api.models.bidding import BiddingResponse, PlaceBidRequest
from config.container import inject
from modules.bidding.application.command import PlaceBidCommand, RetractBidCommand
from modules.bidding.application.query.get_bidding_details import GetBiddingDetails

Expand All @@ -17,7 +16,6 @@


@router.get("/bidding/{listing_id}", tags=["bidding"], response_model=BiddingResponse)
@inject
async def get_bidding_details_of_listing(
listing_id, app: Annotated[Application, Depends(get_application)]
):
Expand All @@ -36,7 +34,6 @@ async def get_bidding_details_of_listing(
@router.post(
"/bidding/{listing_id}/place_bid", tags=["bidding"], response_model=BiddingResponse
)
@inject
async def place_bid(
listing_id,
request_body: PlaceBidRequest,
Expand Down Expand Up @@ -69,7 +66,6 @@ async def place_bid(
tags=["bidding"],
response_model=BiddingResponse,
)
@inject
async def retract_bid(
listing_id, app: Annotated[Application, Depends(get_application)]
):
Expand Down
5 changes: 0 additions & 5 deletions src/api/routers/catalog.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

from api.dependencies import Application, User, get_application, get_authenticated_user
from api.models.catalog import ListingIndexModel, ListingReadModel, ListingWriteModel
from config.container import inject
from modules.catalog.application.command import (
CreateListingDraftCommand,
DeleteListingDraftCommand,
Expand Down Expand Up @@ -32,7 +31,6 @@ async def get_all_listings(app: Annotated[Application, Depends(get_application)]


@router.get("/catalog/{listing_id}", tags=["catalog"], response_model=ListingReadModel)
@inject
async def get_listing_details(
listing_id, app: Annotated[Application, Depends(get_application)]
):
Expand All @@ -47,7 +45,6 @@ async def get_listing_details(
@router.post(
"/catalog", tags=["catalog"], status_code=201, response_model=ListingReadModel
)
@inject
async def create_listing(
request_body: ListingWriteModel,
app: Annotated[Application, Depends(get_application)],
Expand All @@ -73,7 +70,6 @@ async def create_listing(
@router.delete(
"/catalog/{listing_id}", tags=["catalog"], status_code=204, response_model=None
)
@inject
async def delete_listing(
listing_id,
app: Annotated[Application, Depends(get_application)],
Expand All @@ -95,7 +91,6 @@ async def delete_listing(
status_code=200,
response_model=ListingReadModel,
)
@inject
async def publish_listing(
listing_id: GenericUUID,
app: Annotated[Application, Depends(get_application)],
Expand Down
2 changes: 0 additions & 2 deletions src/api/routers/iam.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from pydantic import BaseModel

from api.dependencies import TransactionContext, get_transaction_context
from config.container import inject
from modules.iam.application.exceptions import InvalidCredentialsException
from modules.iam.application.services import IamService

Expand All @@ -30,7 +29,6 @@ class LoginResponse(BaseModel):


@router.post("/token", tags=["iam"])
@inject
async def login(
ctx: Annotated[TransactionContext, Depends(get_transaction_context)],
form_data: OAuth2PasswordRequestForm = Depends(),
Expand Down
5 changes: 2 additions & 3 deletions src/config/container.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from dependency_injector import containers, providers
from dependency_injector.containers import Container
from dependency_injector.providers import Dependency, Factory, Provider, Singleton
from dependency_injector.wiring import Provide, inject # noqa
from lato import Application, DependencyProvider, TransactionContext
from pydantic_settings import BaseSettings
from sqlalchemy import create_engine
Expand Down Expand Up @@ -97,9 +96,9 @@ def on_exit_transaction_context(
# raise exception
else:
session.commit()
logger.debug(f"committed")
logger.debug("committed")
session.close()
logger.debug(f"transaction ended")
logger.debug("transaction ended")
logger.correlation_id.set(uuid.UUID(int=0)) # type: ignore

@application.transaction_middleware
Expand Down