fix: replace standalone dependency-audit.yml with org standard thin caller stub#217
fix: replace standalone dependency-audit.yml with org standard thin caller stub#217don-petry wants to merge 29 commits into
Conversation
|
Warning Review limit reached
More reviews will be available in 12 minutes and 47 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe dependency-audit workflow is simplified to delegate all ecosystem detection and vulnerability scanning logic to a centralized org-level reusable workflow. The in-repo job graph (npm, pnpm, govulncheck, cargo-audit, pip-audit) is removed, replaced with a single job that calls ChangesWorkflow Delegation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
CI is green on all primary checks. @petry-projects/org-leads — this PR is ready for review and merge. It resolves the long-standing compliance finding by replacing the out-of-date standalone |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/dependency-audit.yml:
- Around line 32-33: Update the reusable workflow reference for the
dependency-audit job so it uses the exact commit SHA instead of the floating
tag; locate the "dependency-audit" job and replace the uses:
petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@v1
reference with the corresponding commit SHA (the one resolved via the GitHub
API, e.g., 0cb4bba11d7563bf197ad805f12fb8639e4879e4) — make this change first in
the upstream template (petry-projects/.github) and then sync the updated file
into this repository so the workflow here points to the pinned SHA.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 623a0528-780e-499d-b8d0-38650618d3cb
📒 Files selected for processing (1)
.github/workflows/dependency-audit.yml
There was a problem hiding this comment.
Pull request overview
Migrates the repository’s dependency-audit.yml from a standalone, inline implementation to the org-standard thin caller stub that delegates to the centralized reusable workflow, removing the previously unpinned third-party Rust toolchain action from this repo-level workflow.
Changes:
- Replaced the standalone multi-ecosystem audit workflow with the org-standard thin caller stub.
- Delegated execution to
petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@v1.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Auto-rebase failed — merge conflict — this branch has conflicts with Please resolve the conflicts and push: |
e197456 to
f2da3f4
Compare
Superseded by automated re-review at
|
|
Auto-rebase failed — merge conflict — this branch has conflicts with Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
1ecc69b to
7dd04ca
Compare
Auto-rebase complete ✓The PR branch has been successfully rebased onto `main`. Conflict resolutionFile: `.github/workflows/dependency-audit.yml`
Resolution: Kept the PR branch version (thin caller stub). The only difference between main and the PR's base was a SHA pin for `dtolnay/rust-toolchain@stable` → `@29eef336...`. Since the PR replaces the entire standalone workflow with the org-standard thin stub (which delegates all logic — including Rust toolchain setup — to the centrally-maintained reusable), the standalone workflow's pin update is superseded by the PR's change. This falls under the action-pin conflict resolution rule: the PR's approach is the correct one per org standards. New HEAD``` Parent: `761dd4a` (current `main` tip — fix: disable check-suite auto-trigger for Claude and CodeRabbit on .github (#275))
|
Dev-Lead Fix CI — failedPR: #217 | SHA: |
Dev-Lead Fix CI — failedPR: #217 | SHA: |
Dev-Lead Fix CI — exhaustedThis PR has had 2 consecutive engine failures (timeouts or errors). Automated CI fixing has been paused to avoid consuming further tokens. Reason for last failure: Engine invocation failed (exit 1) To re-enable, delete this comment or push a new commit with a substantially different change. |
|
|
Auto-rebase failed — merge conflict — this branch has conflicts with Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with Claude will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
14 similar comments
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
|
@donpetry-bot I'm on it — starting a fresh review now. Results will appear in a few minutes. |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
|
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: 8e291c644dccb33891bca67c0f111b959244117b
Review mode: triage-approved (single reviewer)
Summary
Migrates .github/workflows/dependency-audit.yml from an inline multi-job audit graph to the org-standard thin caller stub that delegates to dependency-audit-reusable.yml. This eliminates the in-repo third-party action usage (incl. the rust-toolchain action) flagged by the compliance audit. Both .github/workflows/ and standards/workflows/ copies are now byte-identical (blob edc1dd9e) and pin the reusable to a verified SHA. Net diff is small (+21/-198, 2 files). Triage already cleared this as low-risk; this is a confirmation review.
Linked issue analysis
Closes #106 (compliance audit: unpinned action in dependency-audit.yml). Substantively addressed: the old job graph that referenced third-party actions is removed and replaced by a single job calling the org reusable workflow, pinned by commit SHA per the org pinning standard.
Findings
- Verified SHA pin: the reusable is pinned to
d3d768dabb7f28cc63283cdfe48630da53700e50 # v1. Confirmed via GitHub API that thev1tag resolves to exactly this SHA — the pin is correct, not guessed. - Files in sync:
.github/workflows/dependency-audit.ymlandstandards/workflows/dependency-audit.ymlnow resolve to the same blob, matching the "copied verbatim" claim and the AGENTS.md source-of-truth standard. - Doc anchor fix: standards header anchor corrected (
#5-...auditym→#7-dependency-audit-dependency-audityml). Minor, harmless. - No unresolved review threads; CodeRabbit's earlier actionable comment was addressed and it subsequently approved.
- Commits since the prior reviewed SHA are merges from
main(unrelated compliance work); they do not alter the net PR change.
CI status
All required checks green: Lint, ShellCheck, CodeQL/Analyze (actions), Agent Security Scan, AgentShield, Secret scan (gitleaks), SonarCloud, CodeRabbit, and dependency-audit / Detect ecosystems all SUCCESS. Ecosystem-specific audit jobs SKIPPED (no matching lockfiles), as expected. reviewDecision is APPROVED.
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.
Superseded by automated re-review at 8e291c6.





Summary
dependency-audit.ymlworkflow (which contained the unpinneddtolnay/rust-toolchain@stableaction) with the org-standard thin caller stubdependency-audit-reusable.yml, which usesrustupdirectly — eliminating the third-party action and its pinning violationstandards/workflows/dependency-audit.ymlper the AGENTS.md standardRoot cause
The standalone workflow was out of sync with the org standard. The reusable workflow was already updated to use
rustupdirectly (no third-party action), but the caller was never migrated from the old standalone form to the thin caller stub.Test plan
dependency-audit.ymlfor unpinned actionsCloses #106
Generated with Claude Code
Summary by CodeRabbit