-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MultiRotor class #1111
base: main
Are you sure you want to change the base?
Add MultiRotor class #1111
Conversation
Hi there!
|
Hey, |
Hey, @plevisse-naarea! The main features of this module have already been implemented. I am currently trying to validate the results obtained from ROSS, following this paper [A general method to predict unbalance responses of geared rotor systems] as reference. For the first case presented in the reference, I achieved results that closely align: However, for the second case, I am noticing some discrepancies and have not yet been able to identify the cause of these differences: |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
==========================================
+ Coverage 82.15% 82.38% +0.23%
==========================================
Files 38 40 +2
Lines 8259 8477 +218
==========================================
+ Hits 6785 6984 +199
- Misses 1474 1493 +19
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This pull request introduces the
MultiRotor
class, initially designed to enable the coupling of multiple rotors using gears. To support this functionality, theGearElement
class is also being implemented.It is important to note that the use of these new classes requires the rotor model to support 6 degrees of freedom.
I will provide updates here as the development progresses.