Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MultiRotor class #1111

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

Conversation

jguarato
Copy link
Contributor

This pull request introduces the MultiRotor class, initially designed to enable the coupling of multiple rotors using gears. To support this functionality, the GearElement class is also being implemented.

It is important to note that the use of these new classes requires the rotor model to support 6 degrees of freedom.

I will provide updates here as the development progresses.

@ross-bott
Copy link
Collaborator

Hi there!
I have marked this issue as stale because it has not had activity for 45 days.
Consider the following options:

  • If the issue refers to a large task, break it in smaller issues that can be solved in
    less than 45 days;
  • Label the issue as wontfix or wontfix for now and close it.

@ross-bott ross-bott added the stale Issues with no activity for a long period label Nov 3, 2024
@plevisse-naarea
Copy link

Hey,
I'm particularly interested in this functionality! Thanks for tackling it. Do you have visibility on when it could be pulled into the main code ? Are there specific issues where I could potentially give a hand ?

@jguarato
Copy link
Contributor Author

Hey, I'm particularly interested in this functionality! Thanks for tackling it. Do you have visibility on when it could be pulled into the main code ? Are there specific issues where I could potentially give a hand ?

Hey, @plevisse-naarea!

The main features of this module have already been implemented. I am currently trying to validate the results obtained from ROSS, following this paper [A general method to predict unbalance responses of geared rotor systems] as reference.

For the first case presented in the reference, I achieved results that closely align:
Node3_2
Node8_2

However, for the second case, I am noticing some discrepancies and have not yet been able to identify the cause of these differences:
response_90

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.11470% with 22 lines in your changes missing coverage. Please review.

Project coverage is 82.38%. Comparing base (b8a7f44) to head (6996519).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ross/multi_rotor.py 88.05% 16 Missing ⚠️
ross/disk_element.py 33.33% 2 Missing ⚠️
ross/rotor_assembly.py 97.18% 2 Missing ⚠️
ross/gear_element.py 97.36% 1 Missing ⚠️
ross/point_mass.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
+ Coverage   82.15%   82.38%   +0.23%     
==========================================
  Files          38       40       +2     
  Lines        8259     8477     +218     
==========================================
+ Hits         6785     6984     +199     
- Misses       1474     1493      +19     
Files with missing lines Coverage Δ
ross/__init__.py 100.00% <100.00%> (ø)
ross/bearing_seal_element.py 92.90% <100.00%> (ø)
ross/element.py 88.88% <100.00%> (+1.85%) ⬆️
ross/shaft_element.py 96.56% <100.00%> (+<0.01%) ⬆️
ross/gear_element.py 97.36% <97.36%> (ø)
ross/point_mass.py 91.50% <50.00%> (ø)
ross/disk_element.py 98.48% <33.33%> (-1.52%) ⬇️
ross/rotor_assembly.py 94.15% <97.18%> (+0.06%) ⬆️
ross/multi_rotor.py 88.05% <88.05%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1084094...6996519. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues with no activity for a long period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants