#04 выполнено домашнее задание #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kataus
reviewed
Feb 6, 2023
|
|
||
| //todo: 2. надо реализовать методы этого класса | ||
| //надо подобрать подходящую структуру данных, тогда решение будет в "две строчки" | ||
| private final LinkedList<Customer> customers = new LinkedList<>(); |
Collaborator
There was a problem hiding this comment.
только LinkedList подойдет? Из поля непонятна решаемая им задача. Если бы объявили как Deque, а уже имплементировали LinkedList - то было бы понятно зачем и отвязано от конкретной реализации
kataus
reviewed
Feb 6, 2023
| } | ||
|
|
||
| public void add(Customer customer, String data) { | ||
| private Map.Entry<Customer, String> cloneKey(Map.Entry<Customer, String> entry) { |
Collaborator
There was a problem hiding this comment.
Принят следующий порядок методов в классе: конструкторы, public, protected, private. Мотивация - общение с внешним миром видим сразу, а за внутренними деталями можно и проскролить класс. При такой привычке просто не ожидаешь публичные методы после приватны
petrelevich
reviewed
Feb 6, 2023
| @@ -1,18 +1,24 @@ | |||
| package homework; | |||
Owner
There was a problem hiding this comment.
не надо пытаться мержить в petrelevich :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.