Reconcile the fragment rule with the editing principles - #38
Open
psychemistz wants to merge 1 commit into
Open
Conversation
The Patterns and Editing principles sections contradict each other on fragments. The principles say to keep "longer spoken sentences, fragments, and changes in pace when they are clear and characteristic of the writer"; the "Dramatic fragmentation" pattern says to use complete sentences. An agent following the pattern literally deletes exactly what the principle protects. Narrows the fragment rule to stacked fragments used for rhythm or drama, which appears to be the intent given that "Robotic rhythm" already covers repetition separately, and states once at the top of the Patterns section that the principles take precedence where the two conflict. This is a judgment call about the skill's own voice rather than a defect, so it is split from the mechanical fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A judgment call about the skill's own rules rather than a defect, so it is split from the mechanical fixes (#37) and can be declined independently.
The Patterns and Editing principles sections contradict each other on fragments.
Editing principles:
Patterns to cut:
An agent reading the Patterns list literally deletes exactly what the principles protect. The Patterns entries read as absolutes while the principles are conditional, and nothing in the file says which wins.
Proposed fix, kept minimal:
I deliberately did not touch any other pattern. If you'd rather resolve this the other way — tightening the principle instead of loosening the pattern — that works equally well for the contradiction; the point is only that an agent currently gets opposite instructions from the same file.
Passes
lint_docs.pyand the build once #37 is in (verified by applying this change on top of that branch); on its own it fails only on the doc violations that #37 fixes.