Skip to content

Reconcile the fragment rule with the editing principles - #38

Open
psychemistz wants to merge 1 commit into
petergyang:mainfrom
psychemistz:fix/fragments-rule
Open

Reconcile the fragment rule with the editing principles#38
psychemistz wants to merge 1 commit into
petergyang:mainfrom
psychemistz:fix/fragments-rule

Conversation

@psychemistz

Copy link
Copy Markdown

A judgment call about the skill's own rules rather than a defect, so it is split from the mechanical fixes (#37) and can be declined independently.

The Patterns and Editing principles sections contradict each other on fragments.

Editing principles:

Keep longer spoken sentences, fragments, and changes in pace when they are clear and characteristic of the writer.

Patterns to cut:

Dramatic fragmentation. … Use complete sentences.

An agent reading the Patterns list literally deletes exactly what the principles protect. The Patterns entries read as absolutes while the principles are conditional, and nothing in the file says which wins.

Proposed fix, kept minimal:

  1. Narrow the fragment rule to stacked fragments used for rhythm or drama. That looks like the original intent, since "Robotic rhythm" already covers repeated shapes separately — so the current wording seems to over-reach rather than to disagree.
  2. State once, at the top of the Patterns section, that the principles take precedence where the two conflict.

I deliberately did not touch any other pattern. If you'd rather resolve this the other way — tightening the principle instead of loosening the pattern — that works equally well for the contradiction; the point is only that an agent currently gets opposite instructions from the same file.

Passes lint_docs.py and the build once #37 is in (verified by applying this change on top of that branch); on its own it fails only on the doc violations that #37 fixes.

The Patterns and Editing principles sections contradict each other on
fragments. The principles say to keep "longer spoken sentences, fragments, and
changes in pace when they are clear and characteristic of the writer"; the
"Dramatic fragmentation" pattern says to use complete sentences. An agent
following the pattern literally deletes exactly what the principle protects.

Narrows the fragment rule to stacked fragments used for rhythm or drama, which
appears to be the intent given that "Robotic rhythm" already covers repetition
separately, and states once at the top of the Patterns section that the
principles take precedence where the two conflict.

This is a judgment call about the skill's own voice rather than a defect, so it
is split from the mechanical fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant