Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a type interface over ptrie to make it easier to use ptries with various types, incl. basic types, string, vector, tuple, variant, and combinations of these.
For types that are vector-ish, we can directly use ptrie's vector-key funcitonality, for other types, we (de-/)serialize to a vector of byte.
It might be possible to integrate this better with the other parts of ptrie. Feedback is welcome. :)
And note: I didn't benchmark how much overhead comes from this (de-/)serialization.
Also:
Add tests that covers most basic cases.
Add dependency on boost::mp11 (used for access of correct variant)
(+small fix)