fix: audit Makefile stale targets and remove gas_benchmark_hardhat.js - #1
Open
peterexcel494-oss wants to merge 1 commit into
Open
fix: audit Makefile stale targets and remove gas_benchmark_hardhat.js#1peterexcel494-oss wants to merge 1 commit into
peterexcel494-oss wants to merge 1 commit into
Conversation
…p#384) - Replace deprecated `soroban contract deploy` with `stellar contract deploy` in deploy-testnet and deploy-local targets (soroban CLI was renamed) - Remove redundant `cargo build` from the build target; `stellar contract build` already compiles the crate to WASM — running both was wasteful - Replace hardcoded `--source alice` placeholder with `DEPLOYER_IDENTITY` env-var; targets now guard against an unset variable and print a clear error - Update help text to document the DEPLOYER_IDENTITY variable - Delete scripts/gas_benchmark_hardhat.js: the script targets an EVM/Hardhat toolchain (ethers.js, 0x Ethereum addresses, gas units) which has no relation to Soroban/Stellar. No package.json, node_modules, or hardhat config exists anywhere in the repository — the script was entirely non-functional. Closes HubDApp#384
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes HubDApp#384
Audit of
dongle-smartcontract/Makefileandscripts/gas_benchmark_hardhat.jsas requested in issue HubDApp#384.What was changed
dongle-smartcontract/Makefilesoroban contract deploy(deprecated CLI)stellar contract deployin bothdeploy-testnetanddeploy-localtargetscargo buildinbuildtargetstellar contract buildalready compiles the crate to WASM; running both was wasteful and could produce confusing output--source aliceplaceholder$(DEPLOYER_IDENTITY)env-var; both deploy targets now guard against the variable being unset and print a descriptive errorDEPLOYER_IDENTITYvariableAll other Makefile targets (
test,test-verbose,test-release,fmt,lint,check,clean,dev,ci) are valid and untouched.scripts/gas_benchmark_hardhat.js— deletedThe script is an EVM/Hardhat benchmark that:
ethers.js/ Hardhat (Node.js toolchain)0x…Ethereum addressespackage.json,node_modules, and ahardhat.config.js— none of which exist anywhere in this repositoryThe file was entirely non-functional in a pure-Rust Soroban repo and is removed.
Testing
cargo testsuite is unaffected.cargo/stellarCLI commands.