Fixed bugs in ETS2/ETS3 when displaying prismatic joints #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added improved handling and validation for prismatic and revolute joint limits in ETS2 and ETS3 teach and plot methods. The teach panel now uses correct joint limits and scaling, and prismatic joint visualization is fixed to reflect actual joint values. Correspondingly, RTBPlot is updated to support new teach panel arguments and correct joint scaling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering the bugs mentioned in #5, I tried to fix the visualization problems of the prismatic joints in the teach methods of both ETS2 and ETS3. The related file RTBPlot is also modified.
I also added improved handling and validation for prismatic and revolute joint limits in ETS2 and ETS3 teach and plot methods. The teach panel now uses correct joint limits and scaling, and prismatic joint visualization is updated to reflect actual joint values. Correspondingly, RTBPlot is updated to support new teach panel arguments and correct joint scaling.
Whether this change will affect other parts of the toolbox still needs further confirmation.