Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe this pull request. Link to relevant GitHub issues, if any.
Joint with
ada_feeding
#154.In service of #112 , this PR implements a WebRTC connection for streaming video from the robot to the client. It implements "Option A" from #112 . Specifically, it launches a headless browser on
lovelace
to be one end of the P2P connection. Although this should not be necessary (see Option B in #112 ), it was the most straightforward to implement given that is the approachstretch_teleop_interface
used.As such, this PR changes the web app's launch procedure on
lovelace
. Whereas earlier one had to launch the web app and the web_video_server, now they have to run:npm run start
(orcd build; python3 -m http.server 3000
if you have already runnpm run build
).node --env-file=.env server.js
node --env-file=.env start_robot_browser.js
(NOTE: The robot browser must be the last of the web app commands to run!)
Explain how this pull request was tested, including but not limited to the below checkmarks.
Setup:
ada_feeding
#154.cd
intofeedingwebapp
npm install --legacy-peer-deps
npx playwright install
(Note: you may have to runnode --env-file=.env start_robot_browser.js
first)Testing:
The below tests were run with the real web app running (see launch procedure above), the real perception launchfile, but the dummy motion action servers.
Before creating a pull request
npm run format
python3 -m black .
in the top-level of this repositoryBefore merging a pull request
Squash and Merge
)