-
Notifications
You must be signed in to change notification settings - Fork 78
Fix compile and c build #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
atticusofsparta
wants to merge
5
commits into
permaweb:main
Choose a base branch
from
atticusofsparta:fix-compile-and-c-build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix compile and c build #1185
atticusofsparta
wants to merge
5
commits into
permaweb:main
from
atticusofsparta:fix-compile-and-c-build
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebcb99b
to
c5cf925
Compare
e2bf556
to
579724e
Compare
579724e
to
6654a0b
Compare
|
||
def inject_c_files(definition: Definition, c_program: str, c_source_files: list, link_libraries: list): | ||
def inject_c_files(definition: Definition, c_program: str, c_source_files: list): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really like this fix to be merged in.
@atticusofsparta Why are the check (build tests) failing? |
Closes #1205. |
Lishkk
approved these changes
Jul 1, 2025
Lishkk
approved these changes
Jul 1, 2025
Lishkk
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates deno cliffy dep and removes unused c deps
Also adds an action to verify that template languages (c and lua for now) can be created and build