Update 64 bit types

[elsabio]

The minimum changes to correct the SAMCLI.DLL crashes are now committed to this branch.

[jandubois]

I'm not sure why you only changed some of the resumeHandle variables to the DWORD_PTR type; I believe they all need to be changed. I've done this in a followup commit. Please let me know if you think this is not correct!

[elsabio]

I believe that also, but I only tested the changes I proposed, expecting to have this very discussion on the merits of changing the rest :-). If you have test cases that exercise them all on a 64 bit Perl (and for regression, 32 bit, and also prior to 5.14) and it passes with all the variables changed in this way, then my confidence would be improved!

The MS published Win32 API, and the lmaccess.h header from the Perl distribution(s) are not 100% consistent in the parameter naming (not relevant except in that searching is less certain) and the types used (which might be).

[jandubois]

On Tue, Oct 21, 2014 at 5:19 PM, elsabio [email protected] wrote:

I believe that also, but I only tested the changes I proposed, expecting to have this very discussion on the merits of changing the rest :-). If you have test cases that exercise them all on a 64 bit Perl (and for regression, 32 bit, and also prior to 5.14) and it passes with all the variables changed in this way, then my confidence would be improved!

I don't have any test cases, and no time to create any. :(

However, changing a DWORD to a DWORD_PTR just increases the amount of
memory allocated to them on Win64. Since they are always passed by
pointer, the worst that can happen is that only the first 4 bytes will
be used and the rest ignored. So the code should be correct either
way.

I see that there is also one instance of a DWORD resumeHandle left in
Win32API::Net. I will change that one as well, and re-release it.

Cheers,
-Jan

[elsabio]

Knowing that the stack is only ever contaning pointers to space for parameters - a fact I was unsure of - makes this a safe change, I agree.

Thank you for your time and attention responding to this issue and reviewing my suggested fix.