Skip to content

Allow stacked methods #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow stacked methods #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c9cf3a
Allow for stacking method calls
rvandam Aug 2, 2022
143987e
Test parsing of stacked method calls
rvandam Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/Perl/Critic/Policy/ValuesAndExpressions/PreventSQLInjection.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,10 @@ sub get_complete_variable {
$is_quoted = 1;
last;
}
elsif ($sibling->isa('PPI::Token::Word')
&& $sibling->method_call()
# allow for stacking method calls, e.g. $foo->bar->baz->dbh->quote
$variable .= $sibling->content();
else {
last;
}
Expand Down
6 changes: 6 additions & 0 deletions t/ValuesAndExpressions/PreventSQLInjection.run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,12 @@ $sql = "UPDATE table_name SET field = " . $dbh->test($value) . "WHERE field = 1"

$sql = "UPDATE table_name SET field = " . $dbh->test($value) . "WHERE field = " . $dbh->quote($value2);

## name Allow stacked calls prior to quoting method
## parms { quoting_methods => 'test' }
## failures 0
## cut

$sql = "UPDATE table_name SET field = " . $foo->bar->baz->dbh->test($value) . "WHERE field = 1";

## name vars in subtest name.
## parms { prefer_upper_case_keywords => 0 }
Expand Down