Fix unix domain socket tests on Windows #10
Conversation
There is no support in FCGI for this type of usage.
|
Tested on Linux and Windows by me |
There was a problem hiding this comment.
Looks OK from here, if this is intended to be a permanent fix (FCGI using Unix sockets on Windows will likely never work). On the other hand, if FCGI might be fixed to work, as one ticket response seemed to suggest, and this is only a temporary fix, I would just comment out the socket() test (leaving the plan skip_all).
|
@PhilterPaper My intent with FCGI is to add tests for functional things. After it, I want to fix the library (not working say, ipv6, deprecated functions). Unix sockets on Windows could be new functionality. |
|
OK, I made your change to the t-test and upgraded my FCGI to 0.82. At least now it will stop bugging me to update it. I take it that so long as Windows doesn't support this kind of socket, you'll skip that OS, and if you do get a fix, you'll re-enable it. Do you also skip sockets on Windows in the FCGI code (not just the t-tests), or is that just "user beware"? Happy Holidays! |
|
@PhilterPaper Yes, something like this. |
There is no support in FCGI for this type of usage.