Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-12339 remove go tip #94

Merged
merged 4 commits into from
Jul 20, 2023
Merged

PMM-12339 remove go tip #94

merged 4 commits into from
Jul 20, 2023

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff marked this pull request as ready for review July 19, 2023 11:33
@ademidoff
Copy link
Member Author

ademidoff commented Jul 19, 2023 •
edited
Loading

@percona/pmm-admins Could you please configure the github actions to run the tests?

Please configure also the reviewers to be assigned by default.

Please configure also the auto-merge.

@ademidoff ademidoff requested review from a team, BupycHuk and JiriCtvrtka and removed request for a team July 19, 2023 11:36
JiriCtvrtka
JiriCtvrtka previously approved these changes Jul 19, 2023
View reviewed changes
BupycHuk
BupycHuk previously approved these changes Jul 19, 2023
View reviewed changes
@ademidoff
Copy link
Member Author

The test failures are unrelated to this PR, tests have been failing since long. We need to fix them in a separate PR IMO.

@artemgavrilov
Copy link

@BupycHuk please setup required rewiewers and set auto-merge (I can't find where to configure it)

@artemgavrilov
Copy link

@atymchuk I think it makes sense to change trigger from on: [push, pull_request] to push on main and pull_request on everything else. (same as in other repos). Otherwise tests triggered twice in PRs.

@ademidoff ademidoff dismissed stale reviews from JiriCtvrtka and BupycHuk via 4ca63a2 July 19, 2023 12:04
@ademidoff
Copy link
Member Author

ademidoff commented Jul 19, 2023 •
edited
Loading

@atymchuk I think it makes sense to change trigger from on: [push, pull_request] to push on main and pull_request on everything else. (same as in other repos). Otherwise tests triggered twice in PRs.

I fixed this one, but the other one doesn't seem to suffer from the same problem. percona/postgres_exporter#142

Could you please remove the need to approve the workflow runs on every push? That seems to be too annoying.

Screenshot 2023-07-19 at 15 06 27

@BupycHuk BupycHuk merged commit d206d79 into main Jul 20, 2023
@BupycHuk BupycHuk deleted the PMM-12339-remove-go-tip branch July 20, 2023 16:35
mprokopov pushed a commit to ozean12/rds_exporter that referenced this pull request Jul 9, 2024
@artemgavrilov @mprokopov
PMM-12339 remove go tip (percona#94)
bdabb45 
* PMM-12339 remove go tip

PMM-12339

https://goreleaser.com/deprecations/?h=rm+dist#-rm-dist

* PMM-12339 refactor go workflow

* PMM-12339 Hix CI

* PMM-12339 avoid triggering tests twice

---------

Co-authored-by: Artem Gavrilov <[email protected]>
mprokopov added a commit to ozean12/rds_exporter that referenced this pull request Jul 9, 2024
@mprokopov @EduSemensati
@askomorokhov @yareach @AlekSi @vlinevych @denisok @percona-csalguero @BupycHuk @blovett @rnovikovP @nikita-b @yonahd @maxknee @JiriCtvrtka @cezmunsta @YaroslavPodorvanov @artemgavrilov @pkadej @dbazhenov
PENG-2776: Bump RDS Exporter (#6)
940bc79 
* Create rds_exporter-component.yaml

* PMM-6120 Use go 1.14 (percona#45)

* PMM-6213 Remove go 1.13 from travis. (percona#46)

* PMM-6213 Remove go 1.13 from travis.

* PMM-6213 Add go 1.15.x

* PMM-6213 Add go tip.

* PMM-6756 Added go 1.15.x. (percona#48)

* [PMM-6756] Added go 1.15.x.

* PMM-6756 Update

* PMM-6756 Update

* PMM-6756 Revert

* Dummy

* PMM-6756 Update golden files

Co-authored-by: Andrii Skomorokhov <[email protected]>
Co-authored-by: Alexey Palazhchenko <[email protected]>

* Overcome the limitation of 100 dbinstances (percona#47)

* ci: rotate integration keys (percona#52)

* Delete .travis.yml

* PMM-7602 Add GitHub Action (percona#53)

* PMM-7602 Add GitHub Action

* PMM-7602 Point actions to forked repo.

* PMM-7602 Removed travis.

* PMM-7602 Use go modules.

* PMM-7602 Fix check.

* PMM-7602 Fix mod.

* PMM-7602 Fix setup.

* PMM-7602 Fix setup.

* PMM-7602 Fix setup.

* add environment

* PMM-7602 Fix tests.

* PMM-7602 Fix codecov

* PMM-7602 defines what to use go get or go install

* PMM-7602 Improve go get/install

* PMM-7602 Improve get promu.

* PMM-7602 Use tools module for tooling.

* PMM-7602 Fix mods.

* PMM-7602 Fix path

* PMM-7602 Fix gocoverutil

Co-authored-by: Denys Kondratenko <[email protected]>

* PPMM-7961 Updated exporter_shared (percona#59)

* PMM-7902 Remove Go 1.15 (percona#60)

* Add docker multistage build (percona#61)

* bring back maxInterval=60 sec (percona#63)

Co-authored-by: Volodymyr Linevych <[email protected]>
Co-authored-by: Volodymyr Linevych <[email protected]>

* PMM-8207 Cleanup. (percona#57)

Co-authored-by: Jiri Ctvrtka <[email protected]>

* add the ReplicaLag metric (percona#51)

* Update README.md (percona#65)

Remove mentioning upstream as we reworked the project entirely. This statement can confuse people

* PMM-6013 change default branch to main (percona#67)

* Support assume role (percona#70)

* assume role

* move credentials into session

* adding .goreleaser.yml (percona#72)

* adding .goreleaser.yml

Signed-off-by: Max Knee <[email protected]>

* adding new line

Signed-off-by: Max Knee <[email protected]>

* Apply suggestions from code review

Co-authored-by: Denys Kondratenko <[email protected]>

* Update .goreleaser.yml

* adding releaser action

Signed-off-by: Max Knee <[email protected]>

* Update release.yml

* Update .goreleaser.yml

* maxknee test docker build

Signed-off-by: Max Knee <[email protected]>

* adding go 1.16

Signed-off-by: Max Knee <[email protected]>

* debugging action

Signed-off-by: Max Knee <[email protected]>

* updating dockerfile

Signed-off-by: Max Knee <[email protected]>

* reverting docker file and adding new releaserfile

Signed-off-by: Max Knee <[email protected]>

Co-authored-by: Denys Kondratenko <[email protected]>

* Update Dockerfile.releaser

* Update .goreleaser.yml

* Update .goreleaser.yml

* Update release.yml

* Update release.yml

* cost exclaimer  (percona#73)

* cost exclaimer and docker push

* Update Makefile

Remove change of makefile

* PMM-9337 Update go 1.17 (percona#77)

* PMM-9337 Update go 1.17

* Fix codecov

Co-authored-by: JiriCtvrtka <[email protected]>

* Fix incorrect version (percona#76)

* Fix incorrect version.

* FIx for releaser itself.

* Removing promu.

* Delete another file related to promu.

* update ldflags

update ldflags to fill correct values for version

* Remove make build.

* Tidy.

* Revert "Tidy."

This reverts commit 472ca26.

* add prometheus again

* add required packages

* Remove make tarball from CI.

* Remove make tarball

* trigger

Co-authored-by: Denys Kondratenko <[email protected]>

* PMM-11049 Typo present in enhanced metrics scraper for rds_exporter (percona#82)

Co-authored-by: cezmunsta <[email protected]>

* PMM-11312 --version (percona#84)

* PMM-11312 --version

* PMM-11312 make feature-build

* PMM-11312 newline

* PMM-11312 rename command

* PMM-11312 just update version

* PMM-7 Add dependabot (percona#85)

* PMM-11497 Update dependencies. (percona#87)

* PMM-11632 rds_exporter ignores DisableEnhancedMetrics (percona#91)

* Discord link has been removed (percona#92)

* PMM-12339 remove go tip (percona#94)

* PMM-12339 remove go tip

PMM-12339

https://goreleaser.com/deprecations/?h=rm+dist#-rm-dist

* PMM-12339 refactor go workflow

* PMM-12339 Hix CI

* PMM-12339 avoid triggering tests twice

---------

Co-authored-by: Artem Gavrilov <[email protected]>

* Rename build to builder

* golang 1.19

* Patch dist

---------

Co-authored-by: Eduardo Rodrigues Semensati <[email protected]>
Co-authored-by: Andrii Skomorokhov <[email protected]>
Co-authored-by: Jaroslav Musil <[email protected]>
Co-authored-by: Andrii Skomorokhov <[email protected]>
Co-authored-by: Alexey Palazhchenko <[email protected]>
Co-authored-by: Volodymyr Linevych <[email protected]>
Co-authored-by: Alex Tymchuk <[email protected]>
Co-authored-by: Denys Kondratenko <[email protected]>
Co-authored-by: Carlos Salguero <[email protected]>
Co-authored-by: Nurlan Moldomurov <[email protected]>
Co-authored-by: Volodymyr Linevych <[email protected]>
Co-authored-by: Jiri Ctvrtka <[email protected]>
Co-authored-by: ben lovett <[email protected]>
Co-authored-by: Roma Novikov <[email protected]>
Co-authored-by: Nikita Beletskii <[email protected]>
Co-authored-by: Yonah Dissen <[email protected]>
Co-authored-by: Max Knee <[email protected]>
Co-authored-by: JiriCtvrtka <[email protected]>
Co-authored-by: cezmunsta <[email protected]>
Co-authored-by: Yaroslav Podorvanov <[email protected]>
Co-authored-by: Artem Gavrilov <[email protected]>
Co-authored-by: Przemyslaw Kadej <[email protected]>
Co-authored-by: Daniil Bazhenov <[email protected]>
Co-authored-by: Artem Gavrilov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiriCtvrtka JiriCtvrtka JiriCtvrtka approved these changes

@BupycHuk BupycHuk BupycHuk left review comments

@artemgavrilov artemgavrilov Awaiting requested review from artemgavrilov

Assignees

@BupycHuk BupycHuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ademidoff @artemgavrilov @BupycHuk @JiriCtvrtka