Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable force_concat_enums #907

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Remove unused variable force_concat_enums #907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions bin/pt-online-schema-change
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5862,8 +5862,6 @@
);
PTDEBUG && _d('Ascend params:', Dumper($asc));

my $force_concat_enums;


my $from = "$tbl->{name} FORCE INDEX(`$index`)";
my $order_by = join(', ', map {$q->quote($_)} @{$index_cols});
Expand Down Expand Up @@ -9396,12 +9394,12 @@
};
if ( $EVAL_ERROR ) {
chomp $EVAL_ERROR;
_die("Error checking --max-load or --critial-load: $EVAL_ERROR. "

Check warning on line 9397 in bin/pt-online-schema-change

View workflow job for this annotation

GitHub Actions / Typos 

"critial" should be "critical".
. "Check that the variables specified for --max-load and "
. "--critical-load are spelled correctly and exist in "
. "SHOW GLOBAL STATUS. Current values for these options are:\n"
. " --max-load " . (join(',', @{$o->get('max-load')})) . "\n"
. " --critial-load " . (join(',', @{$o->get('critical-load')}))

Check warning on line 9402 in bin/pt-online-schema-change

View workflow job for this annotation

GitHub Actions / Typos 

"critial" should be "critical".
, INVALID_PARAMETERS);
}

Expand Down
2 changes: 0 additions & 2 deletions bin/pt-table-checksum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6683,8 +6683,6 @@ sub _nibble_params {
);
PTDEBUG && _d('Ascend params:', Dumper($asc));

my $force_concat_enums;


my $from = "$tbl->{name} FORCE INDEX(`$index`)";
my $order_by = join(', ', map {$q->quote($_)} @{$index_cols});
Expand Down
4 changes: 0 additions & 4 deletions lib/NibbleIterator.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,10 +208,6 @@ sub _nibble_params {
);
PTDEBUG && _d('Ascend params:', Dumper($asc));

# Check if enum fields items are sorted or not.
# If they are sorted we can skip adding CONCAT to improve the queries eficiency.
my $force_concat_enums;

# Make SQL statements, prepared on first call to next(). FROM and
# ORDER BY are the same for all statements. FORCE IDNEX and ORDER BY
# are needed to ensure deterministic nibbling.
Expand Down
4 changes: 4 additions & 0 deletions util/update-modules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,10 @@ if [ ! -f $tool_file ]; then
die "$tool_file does not exist"
fi

if [ -h $tool_file ]; then
die "$tool_file is a symbolic link"
fi

if [ -n "$(head -n 1 $tool_file | grep perl)" ]; then
tool_lang="perl"
else
Expand Down
Loading