Skip to content

Conversation

@boris-ilijic
Copy link
Member

@boris-ilijic boris-ilijic commented Oct 22, 2025

PBM-1607 Powered by Pull Request Badge

Currently, when pbm-agent fails to delete an unsuccessful backup, it swallows the error and reports just:

E [backup/2025-10-21T17:30:34Z] Failed to delete leftover files for canceled backup "2025-10-21T17:30:34Z"

After this change, the actual error will also be logged.

@boris-ilijic boris-ilijic requested a review from Copilot October 22, 2025 11:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error logging in the PBM (Percona Backup for MongoDB) agent by ensuring that actual error details are included when backup deletion fails, rather than being swallowed. The change addresses the issue where only a generic message was logged without the underlying error information.

Key changes:

  • Enhanced error message to include the file name when fetching file parts fails
  • Modified deletion error logging to include the actual error details

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pbm/storage/split_merge_mw.go Added file name to error message when fetching file parts base fails
pbm/backup/backup.go Updated error logging to include actual error details when deletion fails

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@boris-ilijic boris-ilijic marked this pull request as ready for review October 22, 2025 11:23
@boris-ilijic boris-ilijic merged commit 31ebe7a into dev Oct 23, 2025
24 checks passed
@boris-ilijic boris-ilijic deleted the PBM-1607-rm-leftover branch October 23, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants