PMM-14440: avoid default gatherer when standard collectors are enabled #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR conditionally excludes the prometheus.DefaultGatherer when the standard Go runtime or process scrapers are enabled to avoid duplicate metrics. The DefaultGatherer includes Go runtime and process metrics by default, which would conflict with the custom standard.go and standard.process collectors.
Key changes:
- Added logic to detect when
standard.goorstandard.processscrapers are present - Conditionally construct the
prometheus.Gatherersslice to excludeDefaultGathererwhen these scrapers are active
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JiriCtvrtka
approved these changes
Nov 20, 2025
ademidoff
approved these changes
Nov 20, 2025
Co-authored-by: Alex Demidoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature build: Percona-Lab/pmm-submodules#4119