Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inhouse/tableのalign optionは物理ではなく論理プロパティ的なclass名で使う #48

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

itoh4126
Copy link
Collaborator

@itoh4126 itoh4126 commented Jan 6, 2025

tableのstorybook を見ると、人口の列は -align-right なるclassが指定されているのですが右揃えにはなっていません。
tableの実装を見ると、constantstable-align-values で定義された start または end を使うようになっているので、Storybookを -align-end に変更しました。

Copy link
Contributor

@piyoppi piyoppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆‍♂️

@itoh4126 itoh4126 merged commit 506ac15 into main Jan 6, 2025
2 checks passed
@itoh4126 itoh4126 deleted the fix-table-stories-align-classname branch January 6, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants