Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify description for shielded swaps #1560

Merged
merged 3 commits into from
Jul 25, 2024
Merged

modify description for shielded swaps #1560

merged 3 commits into from
Jul 25, 2024

Conversation

TalDerei
Copy link
Contributor

@TalDerei TalDerei commented Jul 25, 2024 •
edited
Loading

references #1548

open to suggestions here

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7245b1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TalDerei TalDerei requested review from hdevalence and a team July 25, 2024 11:55
@TalDerei TalDerei mentioned this pull request Jul 25, 2024
Merged
hdevalence
hdevalence approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TalDerei TalDerei merged commit 3ca061c into main Jul 25, 2024
1 check failed
@TalDerei TalDerei deleted the swap-description branch July 25, 2024 15:27
turbocrime pushed a commit that referenced this pull request Jul 29, 2024
@TalDerei @turbocrime
modify description for shielded swaps (#1560)
7eb19f3 
* emphasize the privacy features and the concept of batch swaps

* description
TalDerei added a commit that referenced this pull request Mar 6, 2025
@TalDerei
modify description for shielded swaps (#1560)
51dc753 
* emphasize the privacy features and the concept of batch swaps

* description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdevalence hdevalence hdevalence approved these changes

@grod220 grod220 grod220 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TalDerei @hdevalence @grod220