Implement safeguards to check plan against the archive #24
Conversation
| &self, | ||
| start: u64, | ||
| archive: &Archive, | ||
| ) -> anyhow::Result<anyhow::Result<()>> { |
There was a problem hiding this comment.
We can probably simplify the signature and the rest of the call stack here, right? It sounds like the inner error is a boolean.
There was a problem hiding this comment.
I did a double-take on the sig too. Even if this is necessary, would appreciate more comments to explain.
There was a problem hiding this comment.
I initially wrote this change with a boolean, but then decided against it, because it's useful to understand and print why a plan failed a check against an archive, and not just that it failed.
As far as the nested results, this is because the first layer can signal spurious failure (io ops failing, whatever the sqlite lib might throw at us), while the latter signals permanent failure. The plan will never succeed against that archive without manual intervention if the inner error is set. By having two layers, we could in a further change add retries around the outer layer. I think distinguishing between "errors you can do something about" and "errors you can't hope to resolve" is good.
|
I haven't actually functionally tested this yet, was focused on #25. @cronokirby I see we need a rebase here: can you do so and then ping me back? Been running the reindexer a lot lately, so I'm happy to give this another go as sanity check. |
This adds some basic checks that the archive has critical blocks required by the plan, and that the geneses required by the plan are also present.
cronokirby
force-pushed
the
cronokirby/archive-safeguards
branch
from
21cb413 to
e4da51d
Compare
|
Used this to run another |
This can help prevent some potential mistakes in creating a plan, by checking that for the steps of the plan, the first and last blocks that it needs are present, and that any genesis it needs is also present. This can prevent off by one mistakes around upgrades in particular, since the genesis won't exist.