ibc-types: bump prost, tendermint, ibc-proto, ics23#94
Merged
erwanor merged 2 commits intopenumbra-zone:mainfrom Dec 7, 2024
Merged
ibc-types: bump prost, tendermint, ibc-proto, ics23#94erwanor merged 2 commits intopenumbra-zone:mainfrom
erwanor merged 2 commits intopenumbra-zone:mainfrom
Conversation
erwanor
approved these changes
Dec 7, 2024
| trusting_period: Some(value.trusting_period.into()), | ||
| unbonding_period: Some(value.unbonding_period.into()), | ||
| max_clock_drift: Some(value.max_clock_drift.into()), | ||
| trusting_period: Some(CometBftDuration(value.trusting_period).into()), |
Contributor
There was a problem hiding this comment.
ACK. This makes sense to me. This is a domain type change, but doesn't affect the wire protocol.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the following dependencies:
The bump to the latest tendermint version required bumping prost, which in turns required updates of ibc-proto and ics23 (where I opted for their latest releases, respectively).
The two larger changes are:
core::time::Durationandprotobuf.google.Durationare now fallible. I introduced a newtype wrapperCometBftDurationto restore the previous behavior saturating ati64::MAX(for seconds) andi32::MAX(for nanos), respectively.tendermint@v0.36.0onwardtendermint::abci::EventAttributebecame an enum with variantsV037andV034, and introduced the fallible accessorsEventAttribute::key_strandEventAttribute::value_str, in addition to the infallibleEventAttribute::key_bytesandEventAttribute::value_bytes. This required changes in manyTryFrom<Event>impls that would previously match on&strkeys and directly move (or parse)Stringvalues. I chose to avoid extra error handling, instead matching on byte-string usingvalue_bytes()(e.g. nowb"packet_src_channel" => {}instead of the previous"packet_src_channel" => {}), and relying onString::from_utf8_lossyfor the values.