ibc-types-lightclients-tendermint: add validity check for validator s…

…et hash
penumbra-zone · Feb 26, 2024 · 49a947c · 49a947c
1 parent ca4cc5e
commit 49a947c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/crates/ibc-types-lightclients-tendermint/src/error.rs b/crates/ibc-types-lightclients-tendermint/src/error.rs
@@ -126,6 +126,11 @@ pub enum Error {
         header_chain_id: String,
         chain_id: String,
     },
+    /// The given hash of the validators does not matches the given hash in the signed header. Expected: `{signed_header_validators_hash}`, got: `{validators_hash}`
+    MismatchValidatorsHashes {
+        validators_hash: Hash,
+        signed_header_validators_hash: Hash,
+    },
     /// invalid raw client id: `{client_id}`
     InvalidRawClientId { client_id: String },
 }

diff --git a/crates/ibc-types-lightclients-tendermint/src/header.rs b/crates/ibc-types-lightclients-tendermint/src/header.rs
@@ -114,6 +114,13 @@ impl TryFrom<RawHeader> for Header {
             });
         }
 
+        if header.validator_set.hash() != header.signed_header.header.validators_hash {
+            return Err(Error::MismatchValidatorsHashes {
+                signed_header_validators_hash: header.signed_header.header.validators_hash,
+                validators_hash: header.validator_set.hash(),
+            });
+        }
+
         Ok(header)
     }
 }