Calculate our own bbox - #290
Merged
Merged
Conversation
The method we used to use, as part of `@mapbox/geojson-extent` used a library called traverse that spent a bunch of time per record doing a bunch of extra work, copying data around, etc. Calculating a bbox for a linestring is easy and just requires looping once through every point iand recording 4 min and max values, so now we do it ourselves. While the `polylines` importer is generally not the slowest part of a large build, this simple change almost doubles importer throughput! As a bonus we get to remove an old dependency that hasn't been published in a few years.
orangejulius
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method we used to use, as part of
@mapbox/geojson-extent, used a library called traverse that spent a bunch of time per record doing a bunch of extra work, copying data around, etc.Calculating a bbox for a linestring is easy and just requires looping once through every point and recording 4 min and max values, so now we do it ourselves.
While the
polylinesimporter is generally not the slowest part of a large build, this simple change almost doubles importer throughput!As a bonus we get to remove an old dependency that hasn't been published in a few years.