Skip to content

fix(json-editor): Corrects JSON editor layout, storybook controls, and accessibility. - #326

Merged
ricmars merged 1 commit into
pegasystems:masterfrom
ghoshArnab:fix/json-editor-overlap
Sep 17, 2026
Merged

fix(json-editor): Corrects JSON editor layout, storybook controls, and accessibility.#326
ricmars merged 1 commit into
pegasystems:masterfrom
ghoshArnab:fix/json-editor-overlap

Conversation

@ghoshArnab

@ghoshArnab ghoshArnab commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary

  • Converts the JSON Editor Storybook story to CSF3 and exposes its supported controls.
  • Prevents overlap between line numbers, highlighted JSON, the caret, helper text, and the footer for large documents.
  • Disables browser spellcheck for JSON input.
  • Uses an accessible green success status token for valid JSON.

Validation

  • Focused JSON Editor tests: 9 passed.
  • Targeted Storybook axe check: no accessibility violations detected.
  • TypeScript, ESLint, Stylelint, Prettier, and diff checks passed.
  • Full gallery tests: 55 suites and 124 tests passed.

@ghoshArnab
ghoshArnab force-pushed the fix/json-editor-overlap branch from ba675bd to 97aa11f Compare September 17, 2026 16:21
@ghoshArnab
ghoshArnab force-pushed the fix/json-editor-overlap branch from 0e0f8bf to 1145e5c Compare September 17, 2026 17:57
@ghoshArnab ghoshArnab changed the title fix(json-editor): Prevents story and editor content overlap. fix(json-editor): Corrects JSON editor layout, storybook controls, and accessibility. Sep 17, 2026
@ricmars
ricmars merged commit 3b7ac2e into pegasystems:master Sep 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricmars ricmars ricmars approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ghoshArnab @ricmars