refactor(frontend): rename step-contract intake vocabulary to submit/QueuedRequest - #871
Merged
Merged
Conversation
…QueuedRequest Scheduler::intake -> Scheduler::submit, IntakeTicket -> QueuedRequest (TicketInner -> QueuedInner), retire_ticket -> retire_queued, module ticket.rs -> request_lifecycle.rs. Channel wiring follows the verb: submit_tx / submissions. The pre-admission typestate handle is named by its state (queued_at, HandleSlot::Queued, and the emitter doc already said "queued request"); submission is the verb at both ends of the channel, matching executor-style submit semantics with verdicts deferred to step(). Not touched: glm52/kv-store native "intake" vocabulary and the legacy contract's SubmittedRequest alias (kv.rs), which leaves with the legacy contract. Verified: cargo check --release (frontend/qwen3/k3, --examples --tests); frontend lib 60 tests, qwen3 frontend_adapter 7, k3 scheduler 8 pass. Signed-off-by: xiaguan <751080330@qq.com>
xiaguan
force-pushed
the
refactor/frontend-scheduler-vocabulary
branch
from
August 14, 2026 09:14
8f9533a to
f381653
Compare
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Step-contract vocabulary rename, no behavior change:
Scheduler::intake(ticket)Scheduler::submit(req)IntakeTicketQueuedRequest(TicketInner→QueuedInner)StepEmitter::retire_ticketStepEmitter::retire_queuedengine/ticket.rsengine/request_lifecycle.rsintake_tx/intake(channel)submit_tx/submissionsWhy
submitis the verb at both ends of the channel (SchedulerHandle::submit→Scheduler::submit), matching executor-style submit semantics; verdicts stay deferred tostep()either way.queued_at,HandleSlot::Queued, the emitter doc's "queued request") — only the type name disagreed.SubmittedRequestwas not available: the legacy contract already occupies it (kv.rstype alias), and renaming legacy code scheduled for deletion isn't worth the churn.Not touched
EngineHandlepath) unchanged.Verification
cargo check --release -p pegainfer-frontend -p pegainfer-qwen3 -p pegainfer-k3 --examples --testspegainfer-frontendlib: 60 passed (incl. engine contract tests)pegainfer-qwen3frontend_adapter: 7 passedpegainfer-k3scheduler: 8 passed