Fix configuration file location under Linux, all files should be crea… #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted in /home/USER/.config/jxplorer
… when running outside of the directory
Author
|
Second commit added, fix jxplorer.sh script, under Linux fails to start application, if starting the script outside of the jxplorer directory. |
Owner
|
Hi Robert,
I haven't had a chance to look at this yet - there has been a lot of back
and forth over config file locations for all the different platforms; we
ended up making it a command line option that you could set.
Which said, I've no objection to making it more linux friendly by
default, although it would be good if it didn't break people's existing
config if that were possible, or impact other platforms...
cheers,
- Chris
…-----
*Dr Christopher Betts*
Pegacat Aerospace
Melbourne, Australia
m: 61 408 533 456
On 1 August 2018 at 04:39, Robert Milasan ***@***.***> wrote:
Under Linux, when running this application, all config files are created
under /home/USER, which is totally unclean and incorrect. All config files
and generally files required by jxplorer should be saved in
/home/USER/.config/jxplorer. This small patch fixes that.
------------------------------
You can view, comment on, or merge this pull request online at:
#4
Commit Summary
- Fix configuration file location under Linux, all files should be
created in /home/USER/.config/jxplorer
File Changes
- *M* gssapi.conf
<https://github.com/pegacat/jxplorer/pull/4/files#diff-0> (4)
- *M* src/com/ca/commons/cbutil/CBUtility.java
<https://github.com/pegacat/jxplorer/pull/4/files#diff-1> (7)
- *M* src/com/ca/directory/jxplorer/JXplorer.java
<https://github.com/pegacat/jxplorer/pull/4/files#diff-2> (2)
Patch Links:
- https://github.com/pegacat/jxplorer/pull/4.patch
- https://github.com/pegacat/jxplorer/pull/4.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMJq8JAVpBT6qzyxaLLDAo_re8-AOAouks5uMKRVgaJpZM4Vo5iz>
.
|
Author
|
It could impact some users, but it must be fix in my opinion. |
|
Maybe it could try to access config at .config and fallback to home dir? this would be really nice to be fixed 👍 |
|
I would recommend having a read about base directory specifications for Linux, such as https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Linux, when running this application, all config files are created under /home/USER, which is totally unclean and incorrect. All config files and generally files required by jxplorer should be saved in /home/USER/.config/jxplorer. This small patch fixes that.