Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update caip-294 to fit extension id as valid target type (caip-341) #9

Open
wants to merge 4 commits into
base: browser-wallet-messaging-interface
Choose a base branch
from

Conversation

ffmcgee725
Copy link

  • Update caip-294 to fit extension id as valid target type 👉🏾 caip341

@adonesky1
Copy link

We should also add this property / description to CAIP-282 here

@adonesky1
Copy link

Also the expected type should be modified here on CAIP-295: targetOrigin should be nested in the new target object. And we should make the CAIP to define/establish the origin type as a pending todo

CAIPs/caip-294.md Outdated Show resolved Hide resolved
CAIPs/caip-294.md Outdated Show resolved Hide resolved
CAIPs/caip-294.md Outdated Show resolved Hide resolved
CAIPs/caip-294.md Outdated Show resolved Hide resolved
@ffmcgee725 ffmcgee725 requested a review from adonesky1 December 12, 2024 17:22
CAIPs/caip-282.md Outdated Show resolved Hide resolved
CAIPs/caip-294.md Outdated Show resolved Hide resolved
@jiexi
Copy link

jiexi commented Dec 12, 2024

Do we envision a world in which a wallet supports multiple transports/interfaces. If so, do we think it makes more sense for those to all be defined in one Wallet announcement event, or in several separate wallet announcement events?

Currently I'm thinking that it should be one wallet announcement event, but that doesn't work with the current data structure. In that case perhaps something like this makes more sense again

{
  uuid: '1-1-1-1',
  icon: 'blah',
  name: 'wallet name',
  rdns: 'io.wallet',
  target: {
    caip314: 'abcdefghijklmnop',
    caip315: true,
    caip316: {
      someOtherThing: 'hello'
    }
  }
}

@ffmcgee725 ffmcgee725 requested a review from jiexi December 12, 2024 18:44
@adonesky1
Copy link

Do we envision a world in which a wallet supports multiple transports/interfaces. If so, do we think it makes more sense for those to all be defined in one Wallet announcement event, or in several separate wallet announcement events?

Worth discussing. I would think wallets would generally tend towards supporting one entrypoint/transport for any given context and tell the dapp this is the one to use in this context (platform/browser). Otherwise you're imposing a burden on dapps/libraries to add logic to decide between these options.

But perhaps I'm being short sighted and there are good reasons for offering multiple transport options

@bumblefudge
Copy link

is this ready to go when ChainAgnostic#341 is merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants