-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update caip-294 to fit extension id as valid target type (caip-341) #9
base: browser-wallet-messaging-interface
Are you sure you want to change the base?
Conversation
ffmcgee725
commented
Dec 12, 2024
- Update caip-294 to fit extension id as valid target type 👉🏾 caip341
We should also add this property / description to CAIP-282 here |
Also the expected type should be modified here on CAIP-295: |
Do we envision a world in which a wallet supports multiple transports/interfaces. If so, do we think it makes more sense for those to all be defined in one Wallet announcement event, or in several separate wallet announcement events? Currently I'm thinking that it should be one wallet announcement event, but that doesn't work with the current data structure. In that case perhaps something like this makes more sense again
|
Worth discussing. I would think wallets would generally tend towards supporting one entrypoint/transport for any given context and tell the dapp this is the one to use in this context (platform/browser). Otherwise you're imposing a burden on dapps/libraries to add logic to decide between these options. But perhaps I'm being short sighted and there are good reasons for offering multiple transport options |
is this ready to go when ChainAgnostic#341 is merged? |