Skip to content

chore: disable Facebook auth, add message for existing Facebook users #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 23 additions & 21 deletions auth/login/facebook.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from flask import g
from flask import render_template

from ..models import db
from .base import auth, login_blueprint, complete_auth_flow, secure_url_for, prepare_state, validate_state, get_state
Expand All @@ -17,23 +17,25 @@

@login_blueprint.route("/facebook")
def facebook_auth_start():
prepare_state()
return facebook.authorize(secure_url_for('.facebook_auth_complete'))


@login_blueprint.route("/facebook/complete")
def facebook_auth_complete():
validate_state()
resp = facebook.authorized_response()
if resp is None or resp.get('access_token') is None:
return 'Failed.'
g.facebook_token = (resp['access_token'], '')
me = facebook.get('me?fields=id,name,email').data
response = complete_auth_flow(facebook.name, me["id"], me["name"], me.get('email', None))
db.session.commit()
return response


@facebook.tokengetter
def get_token():
return g.facebook_token
# See #32 - Facebook auth disabled due to some weird Facebook issues.
# prepare_state()
# return facebook.authorize(secure_url_for('.facebook_auth_complete'))
return render_template('facebook-not-available.html')


# @login_blueprint.route("/facebook/complete")
# def facebook_auth_complete():
# validate_state()
# resp = facebook.authorized_response()
# if resp is None or resp.get('access_token') is None:
# return 'Failed.'
# g.facebook_token = (resp['access_token'], '')
# me = facebook.get('me?fields=id,name,email').data
# response = complete_auth_flow(facebook.name, me["id"], me["name"], me.get('email', None))
# db.session.commit()
# return response


# @facebook.tokengetter
# def get_token():
# return g.facebook_token
11 changes: 11 additions & 0 deletions auth/templates/facebook-not-available.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{% extends "base.html" %}
{% block body %}
<h2>Facebook authentication is unavailable</h2>
<p>
Due to recent changes in Facebook's requirements, we can no longer provide Facebook authentication.
</p>
<p>
If you previously logged in using Facebook, please contact Rebble via <a href="mailto:[email protected]">email</a> or <a href="https://rebble.io/discord">our Discord server</a> for help getting back into your account.
</p>
<p><a href="/auth">Try logging in again.</a></p>
{% endblock %}