New plugin: Taskbar Progress #4057
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@ArjixWasTaken can you review? |
ArjixWasTaken
requested changes
Nov 29, 2025
Comment on lines
+16
to
+22
| if ( | ||
| !songInfo?.title || | ||
| typeof songInfo.elapsedSeconds !== 'number' || | ||
| !songInfo.songDuration | ||
| ) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
it'd be better to use zod here
Comment on lines
+42
to
+53
| progressInterval = setInterval(() => { | ||
| if ( | ||
| lastSongInfo && | ||
| !lastSongInfo.isPaused && | ||
| typeof lastSongInfo.elapsedSeconds === 'number' | ||
| ) { | ||
| updateProgressBar({ | ||
| ...lastSongInfo, | ||
| elapsedSeconds: lastSongInfo.elapsedSeconds + 1, | ||
| }); | ||
| } | ||
| }, 1000); |
Member
There was a problem hiding this comment.
an interval is not guaranteed to run on a precise manner, could you maybe refactor this to not depend on the interval, and maybe calculate the elapsedSeconds using an external variable?
e.g.
const intervalStart = performance.now();
setInterval(() => {
const elapsedSeconds = (performance.now() - intervalStart) / 1000;
// ...
}, 1000)| export default createPlugin({ | ||
| name: () => t('plugins.taskbar-progress.name'), | ||
| description: () => t('plugins.taskbar-progress.description'), | ||
| restartNeeded: true, |
Member
There was a problem hiding this comment.
please properly implement the cleanup logic required to turn this into restartNeeded: false, you just need to cleanup some intervals
you cannot unregister the song info callback, but you can remove all side-effects when the plugin is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It shows track playing progress in taskbar:
On pause:
Resolves #2416