feat: use content-type provided by prometheus client, pin airflow 2.6.1 dependencies.#5
Merged
Conversation
3134a57 to
6b68e38
Compare
e6053e1 to
91ae420
Compare
igungor
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prometheus >= 3.2.1, seems to reject
textcontent-type by default, unlessfallback_scrape_protocolis given for the target. Instead of setting fallback on Prometheus, responding with correct/expected content-type would be better.airflow-2.6.1to pin Airflow itself and add upper bounds to the dependencies causing issues.wtforms==2.3.3on CI. Not sure why it was pinned but I think it makes more sense to let Airflow bring whatever version it needs.airflow dags reserializeon CI to make sure DAGs are serialized in to database. Not sure how it was working before. On locally, unless I run scheduler as daemon DAGs are not serialized causingairflow dags unpause <dagname>to fail with;DAG: <dagname> does not exist in 'dag' table. I think it also makes more sense to runreserializeexplicitly to prepare environment.