Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): ensures / is URL encoded in sources auth environment variables (fix #3169) #3170

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

noirbizarre
Copy link
Member

@noirbizarre noirbizarre commented Sep 19, 2024

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

/ was not URL encoded because urllib.parse.quote exclude it by default (targeting querystrings).
This PR ensures it is.
(I'll submit a Python urllib.parse.quote documentation PR too as it says it is safe for path by default, which is not, only in querystring)

Fixes #3169

@noirbizarre noirbizarre added the 🐛 bug Something isn't working label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.20%. Comparing base (ff9e871) to head (852f697).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3170   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files         107      107           
  Lines       10715    10715           
  Branches     2292     2292           
=======================================
  Hits         9237     9237           
  Misses       1015     1015           
  Partials      463      463           
Flag Coverage Δ
unittests 86.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit 5db006a into pdm-project:main Sep 19, 2024
24 checks passed
@noirbizarre noirbizarre deleted the fix/urlencoding branch September 20, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/ is not URL encoded in environment variables
2 participants