Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect ca certs in env vars #3090

Merged
merged 1 commit into from
Aug 12, 2024
Merged

feat: respect ca certs in env vars #3090

merged 1 commit into from
Aug 12, 2024

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Fix #3076

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.68%. Comparing base (865fc62) to head (8ed7d95).
Report is 93 commits behind head on main.

Files with missing lines Patch % Lines
src/pdm/models/session.py 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3090   +/-   ##
=======================================
  Coverage   85.67%   85.68%           
=======================================
  Files         109      109           
  Lines       10958    10964    +6     
  Branches     2393     2394    +1     
=======================================
+ Hits         9388     9394    +6     
  Misses       1083     1083           
  Partials      487      487           
Flag Coverage Δ
unittests 85.47% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit d0ceded into main Aug 12, 2024
23 of 24 checks passed
@frostming frostming deleted the fix/cert-env-var branch August 12, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support REQUESTS_CA_BUNDLE (or vice versa) on non-Linux
1 participant